Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Updating tutorial with clarification for the naming conventions #16767

Closed
wants to merge 1 commit into from
Closed

Updating tutorial with clarification for the naming conventions #16767

wants to merge 1 commit into from

Conversation

joej164
Copy link
Contributor

@joej164 joej164 commented Nov 23, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Documentation update

What is the current behavior? (You can also link to an open issue here)
When I was reading the tutorial a section of how controller naming was unclear to me.

What is the new behavior (if this is a feature change)?
Adds some clarification to the docs

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • [X ] The commit message follows our guidelines
  • [X ] Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

Did an initial PR here. Not sure how to update that one, so I instead created a new one.
#16740 (comment)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@joej164
Copy link
Contributor Author

joej164 commented Nov 23, 2018

need to update my other PR, cancelling this

@joej164 joej164 closed this Nov 23, 2018
@joej164 joej164 reopened this Nov 23, 2018
@joej164 joej164 closed this Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants